prevent sorting of PATH dirs for kubectl plugins #70443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
juanvallejo
changed the title
This patch allows the `kubectl plugin list` command to display discovered plugin paths in the same order as they appear in a user's PATH. Prior to this patch, discovered plugin paths were sorted before being displayed. Additionally, any errors encountered while reading from any directory in a user's PATH will now be printed to stderr at the end of the command's output.
juanvallejo
force-pushed
the
jvallejo/plugin-list-improvements
branch
from
ec59d18 to
901c798
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanvallejo, seans3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
jpetazzo
added a commit
to jpetazzo/container.training
that referenced
this pull request
Nov 2, 2018
kubectl logs -l ... --tail ... is buggy. (It always returns 10 lines of output instead of the requested number.) This works around the problem, by adding extra explanations of the issue and providing a shell function as a workaround. See kubernetes/kubernetes#70443 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the
kubectl plugin listcommand to display discoveredplugin paths in the same order as they appear in a user's PATH.
Prior to this patch, discovered plugin paths were sorted before being
displayed.
Additionally, any errors encountered while reading from any directory in a
user's PATH will now be printed to stderr at the end of the command's
output.
/kind bug
Does this PR introduce a user-facing change?:
/sig cli
cc @soltysh @seans3