Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving the cloudprovider interface to staging. #68310

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Moving the cloudprovider interface to staging. #68310

merged 1 commit into from
Oct 5, 2018

Conversation

cheftako
Copy link
Member

@cheftako cheftako commented Sep 6, 2018 •
edited
Loading

What this PR does / why we need it:
Individual implementations are not yet being moved.
Fixed all dependencies which call the interface.
Fixed golint exceptions to reflect the move.
One of the first steps for /~https://github.com/kubernetes/community/blob/master/keps/sig-cloud-provider/0013-build-deploy-ccm.md

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # KEP-0013

Special notes for your reviewer:

Release note:

Any external provider should be aware the cloud-provider interface should be imported from :-
cloudprovider "k8s.io/cloud-provider"

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2018
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 19, 2018
@cheftako
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance

andrewsykim
andrewsykim reviewed Sep 20, 2018
View reviewed changes
hack/.golint_failures Outdated
@@ -686,6 +685,7 @@ staging/src/k8s.io/client-go/util/jsonpath
staging/src/k8s.io/client-go/util/retry
staging/src/k8s.io/client-go/util/testing
staging/src/k8s.io/client-go/util/workqueue
staging/src/k8s.co/cloud-provider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/k8s.co/k8s.io

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL. Thank you :D

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 20, 2018
@andrewsykim
Copy link
Member

cc @d-nishi @mcrute

@cheftako cheftako force-pushed the cpiMove branch 2 times, most recently from 053362c to 9b92476 Compare September 27, 2018 22:47
@cheftako
Copy link
Member Author

/test pull-kubernetes-integration

@cheftako cheftako mentioned this pull request Oct 4, 2018
Closed
@justinsb
Copy link
Member

justinsb commented Oct 5, 2018

Looks like you pulled the file mode changes out (thank you) and lost your lgtm because of it.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2018
@dims
Copy link
Member

dims commented Oct 5, 2018

/test pull-kubernetes-local-e2e-containerized

@dims
Copy link
Member

dims commented Oct 5, 2018

/approve
/lgtm

Looks good! thanks @cheftako

@dims
Copy link
Member

dims commented Oct 5, 2018

/assign @deads2k @thockin @vishh

lavalamp
lavalamp reviewed Oct 5, 2018
View reviewed changes
cmd/kube-controller-manager/app/plugins.go
@@ -26,7 +26,7 @@ import (
"github.com/golang/glog"

// Cloud providers
"k8s.io/kubernetes/pkg/cloudprovider"
cloudprovider "k8s.io/cloud-provider"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "-" worth it? :)

lavalamp
lavalamp reviewed Oct 5, 2018
View reviewed changes
staging/src/k8s.io/cloud-provider/README.md

## Compatibility

Cloud Providers are expected to keep the HEAD of their implementations in sync
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't sound like a reasonable request?

My (untested) goals for the apply repo look like this: /~https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/RELEASE.md

lavalamp
lavalamp reviewed Oct 5, 2018
View reviewed changes
staging/src/k8s.io/cloud-provider/README.md

## Things you should NOT do

1. Add an cloud provider specific code to this repo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/an/any/

@lavalamp
Copy link
Member

lavalamp commented Oct 5, 2018

/approve

I made some comments on the repo setup .md files; you can address in a followup. (Next time consider sending those first in a separate PR? Not that there should be a next time...)

Also I'll leave a hold in case you think it's worth removing the '-' from the package name; just unhold if not.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 5, 2018
@dims
Copy link
Member

dims commented Oct 5, 2018

/test pull-kubernetes-local-e2e-containerized

@dims
Copy link
Member

dims commented Oct 5, 2018

i am +1 to keeping the -

@hogepodge
Copy link

Also +1 on consistency. /lgtm

@saad-ali
Copy link
Member

saad-ali commented Oct 5, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, dims, hogepodge, justinsb, lavalamp, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lavalamp
Copy link
Member

lavalamp commented Oct 5, 2018

OK in that case:

/hold cancel
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2018
@k8s-ci-robot
Copy link
Contributor

@cheftako: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized f3f46d5 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 13705ac into kubernetes:master Oct 5, 2018
@andrewsykim andrewsykim mentioned this pull request Oct 8, 2018
Closed
@hypnoglow hypnoglow mentioned this pull request Oct 10, 2018
Closed
@warmchang warmchang mentioned this pull request Nov 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@lavalamp lavalamp lavalamp left review comments

@justinsb justinsb justinsb left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@dims dims

@justinsb justinsb

@hogepodge hogepodge

@thockin thockin

@vishh vishh

@deads2k deads2k

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.