rebase gophercloud to support HTTP status 300 in pagination, so listingng Cinder v1/v2 API versions won't break

[rootfs]

What this PR does / why we need it:
Since Cinder block v1/v2 support lands in 1.7, we have to ensure Cinder block api list won't fail due to gophercloud/gophercloud#384.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #47651

Special notes for your reviewer:

@anguslees @NickrenREN

Release note:

Fix Cinder to support http status 300 in pagination

[rootfs]

/assign @NickrenREN @anguslees

[rootfs]

@eparis @childsb

[dims]

+1 LGTM

[eparis]

/approve
/sig sig-openstack

[rootfs]

@k8s-bot pull-kubernetes-verify test this

[rootfs]

@brendandburns can you approve? thanks

[brendandburns]

@k8s-bot pull-kubernetes-federation-e2e-gce test this

[brendandburns]

/approve

[brendandburns]

@rootfs we need an issue to approve. given code freeze.

[NickrenREN]

/cc @k8s-sig-openstack-bugs
/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NickrenREN, brendandburns, eparis, rootfs

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [brendandburns]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[rootfs]

@brendandburns Thanks, I opened issue #47651

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 46151, 47602, 47507, 46203, 47471)

[delfer]

All 1.6.x and 1.7.x releases broken for now (can not work with cinder).
When this PR will be released?

[stuart-warren]

This is really affecting us too on 1.7

Any chance in backporting?

/label cherrypick-candidate :)

[rootfs]

@delfer @stuart-warren what error message did you see when you hit this issue?

[delfer]

@rootfs When kubernetes asks openstack for cinder endpoints it got http error 300 - multiple choices. Means var variants: http://cinder_api/v1, http://cinder_api/v2, http://cinder_api/v3
And only error 300 in logs.

[rootfs]

@delfer @stuart-warren cherry-pick PR opened.

@idvoretskyi can you approve 1.7 cherry pick PR #49026? Thanks

[k8s-cherrypick-bot]

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

[k8s-cherrypick-bot]

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

[jamiehannaford]

Will this make it into 1.7.3? I didn't see it in 1.7.2 release or changelog

[delfer]

Can confirm problem on 1.7.2

Events:
FirstSeen LastSeen Count From SubObjectPath Type Reason Message

---

32s 32s 1 default-scheduler Normal Scheduled Successfully assigned app-2122882019-hxk23 to test-k8s-node-nf-2
32s 32s 1 kubelet, test-k8s-node-nf-2 Normal SuccessfulMountVolume MountVolume.SetUp succeeded for volume "default-token-fcmxr"
31s 13s 6 attachdetach Warning FailedMount AttachVolume.Attach failed for volume "pv" : Expected HTTP response code [200 204] when accessing [GET http://192.168.72.51:8776/], but got 300 instead
{"versions": [{"status": "DEPRECATED", "updated": "2016-05-02T20:25:19Z", "links": [{"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}, {"href": "http://192.168.72.51:8776/v1/", "rel": "self"}], "min_version": "", "version": "", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.volume+json;version=1"}], "id": "v1.0"}, {"status": "SUPPORTED", "updated": "2014-06-28T12:20:21Z", "links": [{"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}, {"href": "http://192.168.72.51:8776/v2/", "rel": "self"}], "min_version": "", "version": "", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.volume+json;version=1"}], "id": "v2.0"}, {"status": "CURRENT", "updated": "2016-02-08T12:20:21Z", "links": [{"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}, {"href": "http://192.168.72.51:8776/v3/", "rel": "self"}], "min_version": "3.0", "version": "3.27", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.volume+json;version=1"}], "id": "v3.0"}]}

Please, cherrypick to 1.7.1 1.7.2 1.7.3

[jamiehannaford]

/cc @wojtek-t

[rootfs]

@jamiehannaford @delfer 1.7 cherrypick landed in release-1.7 branch a day ago. It should be in next 1.7 release.

[arykalin]

Got this on 1.7.2

[andrey01]

yep, same here.. as a temporary workaround one can add the following chunk to your cloud provider conf file, in case if you use Cinder v2:

[BlockStorage]
bs-version=v2

[stuart-warren]

Should be in 1.7.3 /~https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG.md#changelog-since-v172