Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPA Controller: Check for 0-sum request value #39694

Merged
merged 1 commit into from
Jan 11, 2017
Merged

HPA Controller: Check for 0-sum request value #39694

merged 1 commit into from
Jan 11, 2017

Conversation

DirectXMan12
Copy link
Contributor

In certain conditions in which the set of metrics returned by Heapster
is completely disjoint from the set of pods returned by the API server,
we can have a request sum of zero, which can cause a panic (due to
division by zero). This checks for that condition.

Fixes #39680

Release note:

Fixes an HPA-related panic due to division-by-zero.

@DirectXMan12
HPA Controller: Check for 0-sum request value
c830d94 
In certain conditions in which the set of metrics returned by Heapster
is completely disjoint from the set of pods returned by the API server,
we can have a request sum of zero, which can cause a panic (due to
division by zero).  This checks for that condition.

Fixes kubernetes#39680
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@DirectXMan12
Copy link
Contributor Author

cc @gmarek

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 10, 2017
@saad-ali
Copy link
Member

CC @kubernetes/sig-autoscaling-misc

@saad-ali
Copy link
Member

saad-ali commented Jan 10, 2017 •
edited
Loading

In order for this to get into 1.5.2, it will need to be reviewed, merged, and cherry-picked to 1.5 by EOD today (realistically before Wed AM PT)

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit c830d94. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davidopp
Copy link
Member

LGTM

@DirectXMan12 I assume the test you added causes the panic without the patch to utilization.go?

@davidopp davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2017
@saad-ali
Copy link
Member

@k8s-bot gce etcd3 e2e test this

@saad-ali saad-ali added this to the v1.5 milestone Jan 11, 2017
@saad-ali saad-ali mentioned this pull request Jan 11, 2017
Merged
@saad-ali
Copy link
Member

I cherry picked this to 1.5 (PR #39711) to make sure it gets in to 1.5.2 per #39680 (comment)

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 39694, 39383, 39651, 39691, 39497)

@k8s-github-robot k8s-github-robot merged commit bb7d07a into kubernetes:master Jan 11, 2017
k8s-github-robot pushed a commit that referenced this pull request Jan 11, 2017
Merge pull request #39711 from saad-ali/automated-cherry-pick-of-#396…
eb162df 
…94-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #39694 upstream release 1.5

Automated cherry pick of #39694 ("HPA Controller: Check for 0-sum request value") to upstream release 1.5
@DirectXMan12 DirectXMan12 deleted the bug/hpa-panic branch January 11, 2017 15:53
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

@bprashanth bprashanth

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
7 participants
@DirectXMan12 @k8s-reviewable @saad-ali @k8s-ci-robot @davidopp @k8s-github-robot @bprashanth