-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shasum if sha1sum doesn't exist in the path #37362
Conversation
FYI, I still need to manually test this on both mac and linux, so please don't lgtm yet. |
it does LGTM. Feel free to self label when you are confident. |
3563966
to
9356ff0
Compare
I ran the following on both a mac and linux machine:
and got to the endless dots (since #37358 hasn't yet been merged) until I applied the manual fix described in #37257 (comment). I found a minor issue on the mac side, where quoting the new variable causes bash to try and execute "shasum -a1" instead of just "shasum" passing "-a1" as an argument so I've unquoted the variable in the pipe chains and re-pushed my branch. |
Re-tested on linux after pushing the new branch and now both mac & linux appear to be working. Self-applying the lgtm label. |
Automatic merge from submit-queue |
cherry-picked in #37864 |
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
What this PR does / why we need it: bug fix for running upgrade.sh from a mac
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #37355This change is