Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Utilize max-nodes-to-dump to leverage on large scale tests to reduce storage #16718

Merged
merged 1 commit into from
Aug 3, 2024
Merged

test: Utilize max-nodes-to-dump to leverage on large scale tests to reduce storage #16718

merged 1 commit into from
Aug 3, 2024

Conversation

hakuna-matatah
Copy link
Contributor

@hakuna-matatah hakuna-matatah commented Aug 1, 2024 •
edited
Loading

  • Set max-nodes-to-dump to leverage on large scale tests to reduce storage and disable ServiceTrafficDistribution

Fixes kubernetes/test-infra#33190

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2024
@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

cc: @dims

@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah hakuna-matatah force-pushed the master branch 2 times, most recently from 6b654ae to ea98ac4 Compare August 1, 2024 21:26
@hakuna-matatah
Copy link
Contributor Author

Scale test with CLUSTER_NAME scale-5000.periodic.test-cncf-aws.k8s.io seem to have succeeded - https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kops/16718/presubmit-kops-aws-small-scale-amazonvpc-using-cl2/1819095148122869760
And ASG seem to have created without issues.

@hakuna-matatah
Copy link
Contributor Author

hakuna-matatah commented Aug 1, 2024 •
edited
Loading

Now lets try to use the old name which was causing issues with CLUSTER_NAME scale-1000.periodic.test-cncf-aws.k8s.io in our periodics here - https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-kops-aws-scale-amazonvpc-using-cl2/1818950113440043008

@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

Now lets try to use the old name which was causing issues with CLUSTER_NAME scale-1000.periodic.test-cncf-aws.k8s.io in our periodics here - https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-kops-aws-scale-amazonvpc-using-cl2/1818950113440043008

Cluster seem to be created and succeed fine even with this name - https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kops/16718/presubmit-kops-aws-small-scale-amazonvpc-using-cl2/1819123862298693632

@hakuna-matatah hakuna-matatah mentioned this pull request Aug 1, 2024
Closed
@dims
Copy link
Member

dims commented Aug 2, 2024

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@dims
Copy link
Member

dims commented Aug 2, 2024

intentionally pulled the rug under the CI job by deleting the ASG by hand

@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

Error: field spec.kubeAPIserver.featureGates not found in *Cluster

Interesting - I see the field in the kops APIServerComponent defined here and v2/v3 api's and in here the crd spec - /~https://github.com/kubernetes/kops/blob/master/k8s/crds/kops.k8s.io_clusters.yaml#L1913-L1917

why would it throw this error ?

@hakuna-matatah
Copy link
Contributor Author

Error: field spec.kubeAPIserver.featureGates not found in *Cluster

Interesting - I see the field in the kops APIServerComponent defined here and v2/v3 api's and in here the crd spec - /~https://github.com/kubernetes/kops/blob/master/k8s/crds/kops.k8s.io_clusters.yaml#L1913-L1917

why would it throw this error ?

Will try to take it directly off from model to see if it works.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2024
@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah hakuna-matatah force-pushed the master branch 3 times, most recently from 7d1cbbb to c7663f1 Compare August 2, 2024 20:09
@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-ci-robot
Copy link
Contributor

@hakuna-matatah: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-kops-aws-scale-amazonvpc-using-cl2 80b7905 link false /test presubmit-kops-aws-scale-amazonvpc-using-cl2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2024
@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah hakuna-matatah changed the title [wip] Test commit Set max-nodes-to-dump to leverage on large scale tests to reduce storage Aug 3, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2024
@hakuna-matatah
Copy link
Contributor Author

/assign @dims @hakman

Successful test run at small scale here

@hakuna-matatah hakuna-matatah changed the title Set max-nodes-to-dump to leverage on large scale tests to reduce storage Utilize max-nodes-to-dump to leverage on large scale tests to reduce storage Aug 3, 2024
@hakman hakman changed the title Utilize max-nodes-to-dump to leverage on large scale tests to reduce storage test: Utilize max-nodes-to-dump to leverage on large scale tests to reduce storage Aug 3, 2024
@hakman
Copy link
Member

hakman commented Aug 3, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8a98e35 into kubernetes:master Aug 3, 2024
21 of 22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Aug 3, 2024
@rifelpet
Copy link
Member

/milestone v1.31

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.30, v1.31 Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@dims dims

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

AWS 5k Scale tests are failing
5 participants
@hakuna-matatah @dims @k8s-ci-robot @hakman @rifelpet