keps/sig-api-machinery: mark implemented keps #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @liggitt @jeremyrickard |
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
RomanBednar
pushed a commit
to RomanBednar/enhancements
that referenced
this pull request
Jul 30, 2024
* NE-1325: External DNS Operator support for shared VPCs Add the externaldns-operator-aws-assume-role enhancement to add support for sharing a hosted zone between two AWS accounts using assume role. Update the aws-cross-account-dns-zone.md enhancement to include references to externaldns-operator-aws-assume-role as well as clean up some invalid references and add alternative on ExternalID. * Add info about STS in externaldns-operator-aws-assume-role STS isn't supported in ExternalDNS yet. Update the enhancement to reflect our situation of implementing this feature before STS support is added. * externaldns-operator-aws-assume-role review updates - Various clarification and grammatical fixes - Example failure scenario in `Failure Mode` section - Finished `Support Procedures` section - Finished `Implementation History` section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark KEPs for GA features as "implemented".