test/e2e: create CRDs once in the beginning of the tests #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only generate CRDs once in the beginning of the test run. Use the "Ordered" option for the test container so that we can utilize ginkgo.BeforeAll to only do stuff once before the first test. Changing from unordered to ordered shouldn't make a big difference here. Add a cleanup function to remove stale NodeFeatureRule objects that are cluster-scoped and not deleted with the test namespace.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/assign @fmuyassarov |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
size/M
fmuyassarov
reviewed
Dec 14, 2022
There was a problem hiding this comment.
This is looks better than before and more efficient!
Thank you @marquiz
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 68ce582b858a86f08647291ca2961e676727d332
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only generate CRDs once in the beginning of the test run. Use the "Ordered" option for the test container so that we can utilize ginkgo.BeforeAll to only do stuff once before the first test. Changing from unordered to ordered shouldn't make a big difference here.
Add a cleanup function to remove stale NodeFeatureRule objects that are cluster-scoped and not deleted with the test namespace.