-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/e2e: fix topologu-updater cmdline args #960
Conversation
The -kubelet-config-file flag got renamed to -kubelet-config-uri and the expected format changed from plain filepath to URI.
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @fmuyassarov @Ethyling |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
nit: typo in the commit title (topologu)
besides that I wonder why it didn't fail when the PR which changed the commandline was posted
Woops, we missed that one 🙄
That's because our e2e tests are run "after the fact". Not ideal, I know. But thanks to @fmuyassarov that's hopefully going to be addressed soon (kubernetes/test-infra#27755) |
The -kubelet-config-file flag got renamed to -kubelet-config-uri and the expected format changed from plain filepath to URI.