Convert testdata to an empty go module #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/XS
elezar
force-pushed
the
fix-module-test-data
branch
from
8eba4f3 to
8abc3cd
Compare
testdata/go.mod
Outdated
| @@ -0,0 +1,3 @@ | |||
| // This empty go.mod file ensures that the testdata folder is not included | |||
| // in the top-level module. This prevents issues such as unsupported characters | |||
| // in path names. | |||
ArangoGutierrez
approved these changes
Oct 22, 2024
k8s-ci-robot
added
the
approved
This ensures that the testdata folder is not included in the top-level module and prevents issues such as unsupported characters in path names. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
fix-module-test-data
branch
from
8abc3cd to
8ada0b0
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, elezar, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: a2756c78c90ba5dccf4716248615fb3c335adfef
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the testdata folder is not included in the top-level module and prevents issues such as unsupported characters in path names.
See also openshift/oc-mirror#669