Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add enableTaints to helm chart #1091

Merged
merged 1 commit into from
Mar 21, 2023
Merged

feat: add enableTaints to helm chart #1091

merged 1 commit into from
Mar 21, 2023

Conversation

AhmedGrati
Copy link

Resolves #1089.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2023
@k8s-ci-robot k8s-ci-robot requested review from kad and zvonkok March 17, 2023 19:29
@netlify
Copy link

netlify bot commented Mar 17, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 02b3b7c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64197dad3f654b00086af893
😎 Deploy Preview https://deploy-preview-1091--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @AhmedGrati. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2023
marquiz
marquiz approved these changes Mar 18, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good to get this into our Helm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2023
@AhmedGrati AhmedGrati force-pushed the feat-helm-enable-taints branch from 74113d4 to c82e1ad Compare March 18, 2023 11:30
fmuyassarov
fmuyassarov suggested changes Mar 21, 2023
View reviewed changes
@AhmedGrati AhmedGrati force-pushed the feat-helm-enable-taints branch from c82e1ad to b0e026d Compare March 21, 2023 09:23
@AhmedGrati AhmedGrati requested review from fmuyassarov and removed request for kad and zvonkok March 21, 2023 09:23
fmuyassarov
fmuyassarov suggested changes Mar 21, 2023
View reviewed changes
@TessaIO
feat: add enableTaints to helm chart
02b3b7c 
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
@AhmedGrati AhmedGrati force-pushed the feat-helm-enable-taints branch from b0e026d to 02b3b7c Compare March 21, 2023 09:49
@AhmedGrati AhmedGrati requested a review from fmuyassarov March 21, 2023 09:49
fmuyassarov
fmuyassarov reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9096686c65810508c8a423aeb9b764d9a7260a63

@k8s-ci-robot k8s-ci-robot merged commit 821e042 into kubernetes-sigs:master Mar 21, 2023
@AhmedGrati AhmedGrati mentioned this pull request Apr 11, 2023
Closed
9 tasks
@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
@marquiz
Copy link
Contributor

marquiz commented Apr 14, 2023

/cherry-pick release-0.12

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 14, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@marquiz: new pull request created: #1136

In response to this:

/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov requested changes

@marquiz marquiz marquiz approved these changes

Assignees

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm: add config parameter for enabling taints
6 participants
@AhmedGrati @k8s-ci-robot @marquiz @k8s-infra-cherrypick-robot @fmuyassarov @TessaIO