Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GO Update version to 1.20 #1059

Merged
merged 1 commit into from
Feb 16, 2023
Merged

GO Update version to 1.20 #1059

merged 1 commit into from
Feb 16, 2023

Conversation

ArangoGutierrez
Copy link
Contributor

This patch

  • Bumps GO to 1.20
  • Updates deps by running "go mod tidy"

@ArangoGutierrez
GO Update version to 1.20
2859d55 
This patch
- Bumps GO to 1.20
- Updates deps by running "go mod tidy"

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@netlify
Copy link

netlify bot commented Feb 16, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 2859d55
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63edf96c34c183000839e0d1
😎 Deploy Preview https://deploy-preview-1059--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 16, 2023
marquiz
marquiz approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez, let's keep up with the latest and greatest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
@marquiz
Copy link
Contributor

marquiz commented Feb 16, 2023

@ArangoGutierrez, could you also submit a PR against /~https://github.com/kubernetes/test-infra to update the presubmit and postsubmit jobs for the master branch to use v1.20
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2023
@ArangoGutierrez
Copy link
Contributor Author

@ArangoGutierrez, could you also submit a PR against /~https://github.com/kubernetes/test-infra to update the presubmit and postsubmit jobs for the master branch to use v1.20 /hold

You are right, will do after lunch

@ArangoGutierrez
Copy link
Contributor Author

@marquiz -> kubernetes/test-infra#28770

@ArangoGutierrez
Copy link
Contributor Author

/test all
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2023
@ArangoGutierrez ArangoGutierrez requested review from marquiz and removed request for kad and fmuyassarov February 16, 2023 15:48
@fmuyassarov
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b1a2adb71a04a3350f043c425c71f515133e886f

@marquiz
Copy link
Contributor

marquiz commented Feb 16, 2023

/retest

2 similar comments
@ArangoGutierrez
Copy link
Contributor Author

/retest

@ArangoGutierrez
Copy link
Contributor Author

/retest

@ArangoGutierrez
Copy link
Contributor Author

/shrug

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Feb 16, 2023
@ArangoGutierrez
Copy link
Contributor Author

/retest

@marquiz
Copy link
Contributor

marquiz commented Feb 16, 2023

@ArangoGutierrez we might need #1061

@ArangoGutierrez
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit f3402b9 into kubernetes-sigs:master Feb 16, 2023
@ArangoGutierrez ArangoGutierrez deleted the go1-20 branch February 17, 2023 09:16
@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz Awaiting requested review from marquiz

Assignees

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArangoGutierrez @k8s-ci-robot @marquiz @fmuyassarov