-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topology-updater: nrt-api Update to v1alpha2 #1053
topology-updater: nrt-api Update to v1alpha2 #1053
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @jlojosnegros. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jlojosnegros Thanks for the PR! I think we need to propagate
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple and unsurprising to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, jlojosnegros, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 989d4bb7d594b6c351364ed194dcf3aa5b290970
|
apologies for late answer. I think the cleanest option would be to file a separate PR depending on this one and in parallel to #1049 to add the attributes reporting. Now that this is merged we don't have many other options anyway though :) I need to check if was already filed, if not I'd be happy to work on that. |
No worries. I have already started working on that :) should have PR ready to review by tomorrow. |
As part of #1048 we need to update NRT API to
v1alpha2
where new top-level attributes have been added to NRT objects.
We will use this top-level attributes to report new pod fingerprint values. see: #1049
address: #1048
see: this issue for more info about new NRT api version