-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-2.27] Add manual
option to the external_cloud_provider
variable
#11884
[release-2.27] Add manual
option to the external_cloud_provider
variable
#11884
Conversation
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
Hum, is there a particular reason to backport this ? I mean, we would usually only backport bug-fixes (or their dependencies) |
I'd like to say if this #11878 report needs to be added in v2.27.1, and if it doesn't match our original policy, it's fine if it can be closed. |
/remove-lgtm |
Oh, do you mean that was technically fixing a regression ? In that, case, yeah ofc we should backport this 👍
|
I didn't design this feature in the first place, maybe the people before me didn't consider this part either. 😂 /lgtm |
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, tico88612, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #11883
/assign tico88612