Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add debuggable-scheduler at cloudbuild #385

Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat: add debuggable-scheduler at cloudbuild #385

merged 1 commit into from
Nov 8, 2024

Conversation

sanposhiho
Copy link
Member

What type of PR is this?

/kind feature
/area simulator

What this PR does / why we need it:

We need a new container for the debuggable scheduler.

Which issue(s) this PR fixes:

Fixes #384

Special notes for your reviewer:

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/simulator Issues or PRs related to the simulator. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Nov 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2024
@sanposhiho
Copy link
Member Author

@utam0k can you give it a stamp when have time?

@utam0k
Copy link
Member

utam0k commented Nov 8, 2024

Sure!

@utam0k
Copy link
Member

utam0k commented Nov 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0436788 into master Nov 8, 2024
4 of 5 checks passed
@sanposhiho sanposhiho deleted the sanposhiho-patch-4 branch November 9, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@196Ikuchil 196Ikuchil Awaiting requested review from 196Ikuchil

Assignees

@utam0k utam0k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/simulator Issues or PRs related to the simulator. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set up the registry for the debuggable scheduler
3 participants
@sanposhiho @k8s-ci-robot @utam0k