-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce the places where users have to register for using custom plugins #332
Conversation
/retest |
/lgtm |
It seems the linter job failed. Can you check it?
|
@utam0k Please revisit here when have chance. |
Rebased. |
/priority next-release |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanposhiho, utam0k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/area simulator
/kind bug
What this PR does / why we need it:
Before this PR, users had to register their custom plugin names in
registeredOutOfTreeMultiPointName
.This is undocumented and led to this kind of issue: #311.
This PR eliminates the need to register
registeredOutOfTreeMultiPointName
in the first place, rather than documenting the existence ofregisteredOutOfTreeMultiPointName
.Which issue(s) this PR fixes:
Fixes #311
Special notes for your reviewer:
/label tide/merge-method-squash