Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide images for simulator with k8s.gcr.io #19

Closed
sanposhiho opened this issue Sep 2, 2021 · 15 comments
Closed

Provide images for simulator with k8s.gcr.io #19

sanposhiho opened this issue Sep 2, 2021 · 15 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sanposhiho
Copy link
Member

sanposhiho commented Sep 2, 2021

/kind feature
/cc @adtac
/cc @Huang-Wei
/cc @alculquicondor
/assign

Hi team.

what want to do

add images for backend/frontend to k8s.gcr.io

why

Now, when users want to use the simulator, they have to clone this repo, build it and run it(on docker or local).
This is a little inconvenient because it will take them a lot of time to build frontend/backend (maybe because of some huge dependencies).

So it is great if we can provide images for backend/frontend so that users can only have to run these images. wdyt?

Question

  • Are there any requirements for creating the image?
  • Do we need to get someone's approval to create images?

I cannot find anything about these in documentations.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 2, 2021
@alculquicondor
Copy link
Contributor

What other kind of requirements are you referring to?

I would image that the only people that need to approve are the OWNERS of kubernetes/k8s.io and kubernetes/test-infra

@sanposhiho
Copy link
Member Author

Thanks, so I can get theirs approves when I create the PRs.
I was just wondering if there are any special requirements since we will be using GCR resources. If not, it's OK. 👍

And we have to create a google group for push access. Who should we list?

Create a google group for granting push access by adding an email alias for it in groups.yaml.
/~https://github.com/kubernetes/k8s.io/tree/main/k8s.gcr.io#creating-staging-repos

@alculquicondor
Copy link
Contributor

Probably the same as the owners

@sanposhiho
Copy link
Member Author

sanposhiho commented Sep 3, 2021

Okay, I'll get email addresses from the email list of sig/scheduling and list them (and you).

@Huang-Wei
Copy link

@sanposhiho To promote an image to gcr.io, it's two-phased. First the CI job usually builds images on every commit / tag, to staging.gcr.io, and secondly, the project maintainer manually promotes some particular images as the public available ones to gcr.io.

For now you're in the first step, and you're right, you have to configure it in kubernetes/k8s.io, here is a snippet for scheduler-plugins: /~https://github.com/kubernetes/k8s.io/blob/5ee35856af102d0689bd2a5f5bba2a3763876d3c/groups/groups.yaml#L1126-L1135.

After you get the image built properly, you should be able to see it in staging.gcr.io.

Then you can start to kick the second step - promoting to gcr.io:

@sanposhiho
Copy link
Member Author

@Huang-Wei
Got it. Thanks for the details.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2021
@sanposhiho
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 6, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2022
@sanposhiho
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2022
@sanposhiho
Copy link
Member Author

/triage accepted
Not to mark as stale.

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jun 3, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 1, 2022
@sanposhiho
Copy link
Member Author

I think we can close it.
/close

@k8s-ci-robot
Copy link
Contributor

@sanposhiho: Closing this issue.

In response to this:

I think we can close it.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants