perf: check validity before constructing a new set of requirements #2011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When checking if a Pod will work on an existing Node, we validate in several ways including
checking the Pods requirements vs the Node's requirements. If it fails at any step,
we need to leave the Node's requirements unchanged. Previously we were:
This changes the order so that we check for compatibility with the Pod first so that
in the case of a Pod not being compatible, we can avoid the allocation that occurs when
creating the temporary set of requirements.
How was this change tested?
Unit testing & deployed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.