-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix ConsolidationState()
test failure in state testing
#1957
test: Fix ConsolidationState()
test failure in state testing
#1957
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 13126502959Details
💛 - Coveralls |
27901aa
to
e7dde75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Fixes #N/A
Description
Fix test flakes coming from the
ConsolidationState()
and DataRace checks inside of the test suite. Resetting the cluster state without using a wait group to complete the goroutine was causing the data race during the Data Race test and not properly resetting all of the details inside of cluster state was causing theConsolidationState()
test to fail.How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.