Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix ConsolidationState() test failure in state testing #1957

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

Fix test flakes coming from the ConsolidationState() and DataRace checks inside of the test suite. Resetting the cluster state without using a wait group to complete the goroutine was causing the data race during the Data Race test and not properly resetting all of the details inside of cluster state was causing the ConsolidationState() test to fail.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2025
@coveralls
Copy link

coveralls commented Feb 4, 2025

Pull Request Test Coverage Report for Build 13126502959

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.008%) to 81.2%

Files with Coverage Reduction New Missed Lines %
pkg/utils/termination/termination.go 2 92.31%
pkg/test/expectations/expectations.go 2 94.42%
Totals Coverage Status
Change from base Build 13123591258: 0.008%
Covered Lines: 9092
Relevant Lines: 11197

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the fix-consolidation-test-flake branch from 27901aa to e7dde75 Compare February 4, 2025 01:35
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7a3e97b into kubernetes-sigs:main Feb 4, 2025
13 checks passed
rschalo pushed a commit to rschalo/karpenter that referenced this pull request Feb 27, 2025
rschalo pushed a commit to rschalo/karpenter that referenced this pull request Feb 27, 2025
rschalo pushed a commit to rschalo/karpenter that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants