fix(txt-suffix): avoid crash on domain without dot

[titilambert]

Description

This PR fix issue when suffix is used and the domain has no dot

Fixes #1668

Checklist

• Unit tests updated
• [N/A] End user documentation updated

[k8s-ci-robot]

Hi @titilambert. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mloiseleur]

/retitle fix(txt-suffix): avoid crash on domain without dot

[mloiseleur]

/ok-to-test
@titilambert Wdyt of adding a log, too ?

[titilambert]

/ok-to-test @titilambert Wdyt of adding a log, too ?

Good idea ! I will add a commit later today.

[titilambert]

/ok-to-test @titilambert Wdyt of adding a log, too ?

Done !

[mloiseleur]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

* [85a4b15](/~https://github.com/kubernetes-sigs/external-dns/commits/85a4b154f160819dcc8f469414d5e90fde1d64f8) Fix [wrong host entry crashes the whole external-dns pod #1668](/~https://github.com/kubernetes-sigs/external-dns/issues/1668)

@titilambert You have to fix this commit, too.

[titilambert]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.
The list of commits with invalid commit messages:

* [85a4b15](/~https://github.com/kubernetes-sigs/external-dns/commits/85a4b154f160819dcc8f469414d5e90fde1d64f8) Fix [wrong host entry crashes the whole external-dns pod #1668](/~https://github.com/kubernetes-sigs/external-dns/issues/1668)

@titilambert You have to fix this commit, too.

Sorry, I missed it. I just squashed, changed commit message and force pushed.

[titilambert]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.
The list of commits with invalid commit messages:

* [85a4b15](/~https://github.com/kubernetes-sigs/external-dns/commits/85a4b154f160819dcc8f469414d5e90fde1d64f8) Fix [wrong host entry crashes the whole external-dns pod #1668](/~https://github.com/kubernetes-sigs/external-dns/issues/1668)

@titilambert You have to fix this commit, too.

Sorry, I missed it. I just squashed, changed commit message and force pushed.

Done

[mloiseleur]

/lgtm
/assign @Raffo

@Raffo: I'll let you decide if we should keep or not those debug logs.

[Raffo]

I don't think they are super informative and won't really help in a running system. I understand the use for development, but I think we should remove them. Can you take care of this @titilambert ?

[titilambert]

I don't think they are super informative and won't really help in a running system. I understand the use for development, but I think we should remove them. Can you take care of this @titilambert ?

done !

[titilambert]

@Raffo @mloiseleur I think I completed everything, so It should be ready for review.

Thanks again !

[Raffo]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Raffo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Raffo]

/hold

[Raffo]

Removing hold once I've seen CI pass, I didn't realize that it didn't re-run.

[Raffo]

This will merge.