Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refactor title and organisation #4726

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Sep 5, 2024

Description

  1. Reduce title length in order to get a readable left menu.
  2. Move tutorials related to sources to sources section, like the others
  3. Fix some markdown formatting issues
  4. Removes an invalid field in mkdocs configuration: trademark
  5. Fixes Minikube externaldns + coredns documentation is out of date #4723 by warning user.

Current left menu:
image

With this PR, the left menu:
image

Checklist

  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2024
@k8s-ci-robot k8s-ci-robot requested a review from szuecs September 5, 2024 07:19
@szuecs
Copy link
Contributor

szuecs commented Sep 5, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@mloiseleur
Copy link
Contributor Author

@szuecs I can self approve but I cannot self lgtm
/lgtm

@k8s-ci-robot
Copy link
Contributor

@mloiseleur: you cannot LGTM your own PR.

In response to this:

@szuecs I can self approve but I cannot self lgtm
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Raffo
Copy link
Contributor

Raffo commented Sep 5, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7bdb0f6 into kubernetes-sigs:master Sep 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minikube externaldns + coredns documentation is out of date
4 participants