-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Bump k8s libraries to 1.14.1 #204
Conversation
@DirectXMan12 @droot @pwittrock any chance to merge this? |
/assign @DirectXMan12 @droot @pwittrock |
We don't have our e2e tests that run in CT specifically back in shape yet. Have you tested this with a KB sample project yet? Flattening shouldn't break on the recursive structure in metadata, but I'd rather have a test in place. |
I tested this against the kubebuilder project-v2 test project using The only difference in the generated output was that the fields from master
got changed to
|
schema-gen would stack-overflow on recursive structures, which wasn't a problem until 1.14, which has managedFields in objectmeta (which we also handle specially to get a good flattened schema).
6406337
to
3e27ed2
Compare
/lgtm added special handling for managedFields to avoid issues with recursion (doesn't show up till the corresponding project is updated to 1.14, but wanted to head that off) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#186 with another dep run.