Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Bump k8s libraries to 1.14.1 #204

Merged
merged 4 commits into from
May 15, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 8, 2019

#186 with another dep run.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from deads2k and droot May 8, 2019 20:44
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 8, 2019
@sttts
Copy link
Contributor Author

sttts commented May 10, 2019

@DirectXMan12 @droot @pwittrock any chance to merge this?

@sttts
Copy link
Contributor Author

sttts commented May 10, 2019

/assign @DirectXMan12 @droot @pwittrock

@DirectXMan12
Copy link
Contributor

We don't have our e2e tests that run in CT specifically back in shape yet. Have you tested this with a KB sample project yet? Flattening shouldn't break on the recursive structure in metadata, but I'd rather have a test in place.

@damemi
Copy link
Contributor

damemi commented May 14, 2019

I tested this against the kubebuilder project-v2 test project using ./controller-gen paths=./api/... and didn't seem to have any problems, and I got the same set of changes as running from controller-tools master (a couple generated CRDs and an updated zz_deepcopy.go).

The only difference in the generated output was that the fields from master

status:
  conditions: []
  storedVersions: []

got changed to null in this branch:

status:
  conditions: null
  storedVersions: null

damemi and others added 4 commits May 15, 2019 16:07
schema-gen would stack-overflow on recursive structures, which wasn't a
problem until 1.14, which has managedFields in objectmeta (which we also
handle specially to get a good flattened schema).
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

added special handling for managedFields to avoid issues with recursion (doesn't show up till the corresponding project is updated to 1.14, but wanted to head that off)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@DirectXMan12 DirectXMan12 changed the title Bump k8s libraries to 1.14.1 ⚠️ Bump k8s libraries to 1.14.1 May 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5593306 into kubernetes-sigs:master May 15, 2019
@sttts sttts deleted the k8s-1.14-bump branch May 16, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants