-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump controller-tools to v0.14 #9987
🌱 Bump controller-tools to v0.14 #9987
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
/hold have to find some time to review the diff myself :) But at a first glance it looks okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 0f0cc51d4b85cc7c38fe5eec0ed25ed07fd0e48e
|
Also reviewed the PR. Diff in CRDs is only in description fields (the diffs are intended). I'm going to merge this now given lgtm above and that we do not want to rebase this PR. /approve Feel free to review and let me know if there is anything to follow-up on. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #9578