📖 Refactor provider's implementers guide #11195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
I like the layout changes and the edits. This is a definite improvement. Great work @fabriziopandini 👍 |
fabriziopandini
commented
Sep 18, 2024
docs/book/src/developer/providers/implementers-guide/overview.md
Outdated
Show resolved
Hide resolved
fabriziopandini
commented
Sep 18, 2024
sbueringer
reviewed
Sep 19, 2024
docs/book/src/developer/providers/getting-started/initialize-repo-and-api-types.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/providers/getting-started/initialize-repo-and-api-types.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/providers/getting-started/initialize-repo-and-api-types.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/providers/getting-started/controllers-and-reconciliation.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/providers/getting-started/configure-the-deployment.md
Outdated
Show resolved
Hide resolved
|
All comment addressed |
k8s-ci-robot
added
the
do-not-merge/hold
|
Thx! /lgtm (you can also just add the squash label and let tide do the work/squash) |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 713ff77ad033fe27c6eb5b1d43aa9b987775e9c8
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
force-pushed
the
refactor-implementers-guide
branch
2 times, most recently
from
2c51281 to
8a13748
Compare
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
fabriziopandini
force-pushed
the
refactor-implementers-guide
branch
from
8a13748 to
fe7b6b4
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 90db2dab7c8ebc480aba42ddfbd52efaa5079cc9
|
59 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Provider's implementers guide have some good content, but the current book structure and page order doesn't surface what it is.
This refactor:
PS. most probably, the easiest way to look at this is by using the preview of the web site
/area documentation