-
Notifications
You must be signed in to change notification settings - Fork 88
validates contents contained in createdRBACObj in aggregated test #209
Conversation
Thanks, @onyiny-ang! I think you might want to rebase this on top of #207 and see if it's still needed/rework it as necessary? |
@onyiny-ang In response to your question about testing:
|
/ok-to-test |
@onyiny-ang Is this ready for review? Or should I wait to look until after #207 is in? |
@perotinus I've rebased it to include the merged #207. All the tests still pass but it still doesn't test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: onyiny-ang, perotinus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig multicluster
This is a follow up PR to #170 which adds validation of the contents of the RBAC Object in the crinit aggregated test
Hopefully closes issue: #114
If it doesn't, please let me know what else needs to be done to satisfy this issue and I can work on it.