Skip to content
This repository has been archived by the owner on Mar 26, 2021. It is now read-only.

validates contents contained in createdRBACObj in aggregated test #209

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

onyiny-ang
Copy link
Contributor

/sig multicluster

This is a follow up PR to #170 which adds validation of the contents of the RBAC Object in the crinit aggregated test

Hopefully closes issue: #114
If it doesn't, please let me know what else needs to be done to satisfy this issue and I can work on it.

@k8s-ci-robot k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2018
@perotinus
Copy link
Contributor

Thanks, @onyiny-ang! I think you might want to rebase this on top of #207 and see if it's still needed/rework it as necessary?

@perotinus
Copy link
Contributor

@onyiny-ang In response to your question about testing:

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2018
@jdumars
Copy link

jdumars commented Mar 2, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 2, 2018
@perotinus
Copy link
Contributor

@onyiny-ang Is this ready for review? Or should I wait to look until after #207 is in?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 9, 2018
@onyiny-ang
Copy link
Contributor Author

onyiny-ang commented Apr 9, 2018

@perotinus I've rebased it to include the merged #207. All the tests still pass but it still doesn't test waitForAggregator at this point.

@perotinus
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: onyiny-ang, perotinus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8ec3a68 into kubernetes-retired:master Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants