Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disallow block volume capability #310

Merged
merged 6 commits into from
Apr 11, 2022
Merged

fix: disallow block volume capability #310

merged 6 commits into from
Apr 11, 2022

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Apr 9, 2022 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: disallow block volume capability
should return error for block volume capability

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: disallow block volume capability

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2022
@coveralls
Copy link

coveralls commented Apr 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2144037952

  • 10 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.09%) to 75.779%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nfs/controllerserver.go 10 12 83.33%
Files with Coverage Reduction New Missed Lines %
pkg/nfs/controllerserver.go 13 70.24%
Totals Coverage Status
Change from base Build 2098940668: -2.09%
Covered Lines: 535
Relevant Lines: 706
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 9, 2022
@andyzhangx andyzhangx changed the title test: enable external slow tests fix: disallow block volume capability Apr 9, 2022
@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
test: run external inline volume tests
da26b07 
test: enable inline volume in external e2e tests

fix inline volume tests

fix format

shared
@andyzhangx
Copy link
Member Author

/test pull-csi-driver-nfs-external-e2e

@andyzhangx andyzhangx merged commit 69353dd into kubernetes-csi:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-griffith j-griffith Awaiting requested review from j-griffith

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @coveralls