Update k8s and x/net dependencies #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckotzbauer
previously approved these changes
Dec 19, 2024
|
Can somebody please review the Fossa (License compliance) problems indicated, so we can merge this and unblock the some other PRs with this as well? |
Signed-off-by: Daniel Holbach <daniel.holbach@gmail.com>
evrardjp
force-pushed
the
update
branch
2 times, most recently
from
5502b71 to
0bec002
Compare
|
Seems like the golang.org/x/text version include translated text with CC license. I am now excluding the version. Let's see if 0.20 is behaving the same way by having it fossa scanned. |
evrardjp
force-pushed
the
update
branch
3 times, most recently
from
0dc6ab1 to
c37aeb8
Compare
Without this, we'll stay in k8s 0.29, and a vulnerable golang/net. This contains other bumps, like bumps to golang.org/x/text, which is flagged by FOSSA as CC licensed. As these CC-licensed code snippets are used in other CNCF projects (like kubernetes), this is fine to bump and will be excluded in our license scans in the future. Closes: kubereboot#1049 Signed-off-by: Jean-Philippe Evrard <open-source@a.spamming.party>
|
Checked the history and other projects. Decided to accept the exclusion. Commit is now updated to reflect it. |
evrardjp
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.