-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Update MLMD version and add process to keep this up to date. #5439
Comments
Note, updating MLMD is fairly complex, we need to update all the 7 locations listed in pipelines/manifests/kustomize/base/metadata/base/metadata-grpc-deployment.yaml Lines 19 to 24 in 1128631
Some of them are not well documented, so I'd suggest delaying the upgrade to next release -- unless you have absolute reasons. |
@Bobgy I have no particular reason for updating it, just something I noticed. Once things settle down a bit more I think it would be interesting to setup Renovate with the regex engine so that it can handle updating MLMD everywhere in the repo in a single PR so it can be tested properly. How does that sound? |
Part of the upgrade requires regenerating a proto client using later proto definitions, so it's unlikely we can configure renovate to do this. But it's very helpful to automate the upgrade, we may add this script to release process |
You can have Renovate execute a script as well, so it might still be possible to fully automate. |
Happy to see that theMLMD version has been upgraded in the latest release. @Bobgy is having this managed by Renovate something you would want to implement? I've been doing quite a bit of stuff with Renovate lately to automate keeping all the manifests for Kubeflow up to date so I might be able to help here. |
@davidspek did you figure out the scriptable update? MLMD would need this, because one step is pulling in new proto definitions and regenerate proto clients. |
Do you maybe have a link to the script that needs to be run and the locations where MLMD needs to be updated? It would save me some time looking for it. If not, it isn't a problem either. Then I can test on my fork to try and get this setup. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/cc @zijianjoy |
Thank you David and Yuan! This is the link to the MLMD upgrade script guide: /~https://github.com/kubeflow/pipelines/tree/master/third_party/ml-metadata#upgrade-mlmd-versions |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@zijianjoy @Bobgy @chensun, I see that we are now very behind again on the Any chance someone can manually do another update? |
We are currently waiting for ML Metadata 1.14 to be released. Once it is available, we will upgrade to this version. |
Closing this issue as ML Metadata 1.14 is already released and manifests upgraded. /close |
@rimolive: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently pipelines uses gcr.io/tfx-oss-public/ml_metadata_store_server version
0.25.1
but0.29.0
is the latest version. The image tag in metadata-grpc-deployment.yaml needs updating.To automate this process, all image tags should be listed in the
images:
section of thekustiomization.yaml
files (here for this specific case). Once that is done, Renovate can be setup to create PRs updating the image tags of the manifests.@Bobgy Would you like me to go through the manifests and set the images in the
kustomization.yaml
files and add the necessary Renovate config for kustomize?Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
The text was updated successfully, but these errors were encountered: