Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istio: Include patches and resources in Istio install kustomization #2288

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

dpoulopoulos
Copy link
Contributor

Include the resources and patches in Istio install kustomization. Specifically, include:

  • 'service.yaml' patch
  • 'remove-pdb.yaml' patch
  • 'istio-configmap-disable-tracing.yaml' patch

and:

  • 'gateway_authorizationpolicy.yaml' resource
  • 'deny_all_authorizationpolicy.yaml' resource
  • 'gateway.yaml' resource
  • 'x-forwarded-host.yaml' resource

Signed-off-by: Dimitris Poulopoulos dimpo@arrikto.com

Include the resources and patches in Istio install kustomization.
Specifically, include:

* 'service.yaml' patch
* 'remove-pdb.yaml' patch
* 'istio-configmap-disable-tracing.yaml' patch

and:

* 'gateway_authorizationpolicy.yaml' resource
* 'deny_all_authorizationpolicy.yaml' resource
* 'gateway.yaml' resource
* 'x-forwarded-host.yaml' resource

Signed-off-by: Dimitris Poulopoulos <dimpo@arrikto.com>
@kimwnasptd
Copy link
Member

Thanks you @dpoulopoulos!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dpoulopoulos, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 401a994 into kubeflow:master Sep 29, 2022
@kimwnasptd kimwnasptd deleted the fix-dimpo-istio-patches branch September 29, 2022 15:29
kimwnasptd pushed a commit that referenced this pull request Sep 29, 2022
…2288)

Include the resources and patches in Istio install kustomization.
Specifically, include:

* 'service.yaml' patch
* 'remove-pdb.yaml' patch
* 'istio-configmap-disable-tracing.yaml' patch

and:

* 'gateway_authorizationpolicy.yaml' resource
* 'deny_all_authorizationpolicy.yaml' resource
* 'gateway.yaml' resource
* 'x-forwarded-host.yaml' resource

Signed-off-by: Dimitris Poulopoulos <dimpo@arrikto.com>

Signed-off-by: Dimitris Poulopoulos <dimpo@arrikto.com>
@surajkota
Copy link
Contributor

Thanks

jsitu777 added a commit to awslabs/kubeflow-manifests that referenced this pull request Sep 30, 2022
#446)

**Which issue is resolved by this Pull Request:**
Resolves # 
kubeflow/manifests#2288

**Description of your changes:**
-update istio paths with newest patch update.

**Testing:**
- [ ] Unit tests pass
- [x] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
kevin85421 pushed a commit to juliusvonkohout/manifests that referenced this pull request Feb 28, 2023
…ubeflow#2288)

Include the resources and patches in Istio install kustomization.
Specifically, include:

* 'service.yaml' patch
* 'remove-pdb.yaml' patch
* 'istio-configmap-disable-tracing.yaml' patch

and:

* 'gateway_authorizationpolicy.yaml' resource
* 'deny_all_authorizationpolicy.yaml' resource
* 'gateway.yaml' resource
* 'x-forwarded-host.yaml' resource

Signed-off-by: Dimitris Poulopoulos <dimpo@arrikto.com>

Signed-off-by: Dimitris Poulopoulos <dimpo@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants