-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
istio: Include patches and resources in Istio install kustomization #2288
Merged
google-oss-prow
merged 1 commit into
kubeflow:master
from
arrikto:fix-dimpo-istio-patches
Sep 29, 2022
Merged
istio: Include patches and resources in Istio install kustomization #2288
google-oss-prow
merged 1 commit into
kubeflow:master
from
arrikto:fix-dimpo-istio-patches
Sep 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the resources and patches in Istio install kustomization. Specifically, include: * 'service.yaml' patch * 'remove-pdb.yaml' patch * 'istio-configmap-disable-tracing.yaml' patch and: * 'gateway_authorizationpolicy.yaml' resource * 'deny_all_authorizationpolicy.yaml' resource * 'gateway.yaml' resource * 'x-forwarded-host.yaml' resource Signed-off-by: Dimitris Poulopoulos <dimpo@arrikto.com>
Thanks you @dpoulopoulos! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dpoulopoulos, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kimwnasptd
pushed a commit
that referenced
this pull request
Sep 29, 2022
…2288) Include the resources and patches in Istio install kustomization. Specifically, include: * 'service.yaml' patch * 'remove-pdb.yaml' patch * 'istio-configmap-disable-tracing.yaml' patch and: * 'gateway_authorizationpolicy.yaml' resource * 'deny_all_authorizationpolicy.yaml' resource * 'gateway.yaml' resource * 'x-forwarded-host.yaml' resource Signed-off-by: Dimitris Poulopoulos <dimpo@arrikto.com> Signed-off-by: Dimitris Poulopoulos <dimpo@arrikto.com>
This was referenced Sep 29, 2022
Thanks |
2 tasks
jsitu777
added a commit
to awslabs/kubeflow-manifests
that referenced
this pull request
Sep 30, 2022
#446) **Which issue is resolved by this Pull Request:** Resolves # kubeflow/manifests#2288 **Description of your changes:** -update istio paths with newest patch update. **Testing:** - [ ] Unit tests pass - [x] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
kevin85421
pushed a commit
to juliusvonkohout/manifests
that referenced
this pull request
Feb 28, 2023
…ubeflow#2288) Include the resources and patches in Istio install kustomization. Specifically, include: * 'service.yaml' patch * 'remove-pdb.yaml' patch * 'istio-configmap-disable-tracing.yaml' patch and: * 'gateway_authorizationpolicy.yaml' resource * 'deny_all_authorizationpolicy.yaml' resource * 'gateway.yaml' resource * 'x-forwarded-host.yaml' resource Signed-off-by: Dimitris Poulopoulos <dimpo@arrikto.com> Signed-off-by: Dimitris Poulopoulos <dimpo@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the resources and patches in Istio install kustomization. Specifically, include:
and:
Signed-off-by: Dimitris Poulopoulos dimpo@arrikto.com