Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to use kube-system as default namespace to look for confi… #88

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Switch back to use kube-system as default namespace to look for confi… #88

merged 1 commit into from
Jan 22, 2024

Conversation

lubronzhan
Copy link
Collaborator

@lubronzhan lubronzhan commented Jan 19, 2024 •
edited
Loading

…g map of pool

Fix #87
This was reverted in #63
Will cut a new 0.0.9 release later

Tested

I0119 22:44:57.512025       1 provider.go:59] Watching configMap for pool config with name: 'kubevip', namespace: 'kube-system'

@lubronzhan
Switch back to use kube-system as default namespace to look for confi…
4380fe3 
…g map of pool

Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
@lubronzhan lubronzhan requested a review from thebsdbox January 19, 2024 21:47
@lubronzhan lubronzhan merged commit b93fe84 into kube-vip:main Jan 22, 2024
5 checks passed
@lubronzhan lubronzhan deleted the topic/lubron/fix-87 branch January 22, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebsdbox thebsdbox Awaiting requested review from thebsdbox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Right now by default kvcp assume kubevip configmap is inside default namespace
1 participant
@lubronzhan