Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: ensure that test-target is executed always #135

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

pnxs
Copy link
Contributor

@pnxs pnxs commented Mar 12, 2024

The recent actions of the "Build and Test" workflow did not execute the unittests anymore.
Output was only "(make: 'test' is up to date.)"
This commit adds "test" as phony target in make.
Solved a Bug in FindFreeAddress() introduced with 7b00941

Signed-off-by: Thomas Schätzlein <thomas@pnxs.de>
Signed-off-by: Thomas Schätzlein <thomas@pnxs.de>
@lubronzhan
Copy link
Collaborator

Thanks! Good catch!

@lubronzhan
Copy link
Collaborator

I guess the best practice is to put .PHONY on top of each target

@lubronzhan
Copy link
Collaborator

Copy link
Collaborator

@lubronzhan lubronzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubronzhan
Copy link
Collaborator

Do you have the permission to merge the PR? If not I can merge it

@pnxs
Copy link
Contributor Author

pnxs commented Mar 14, 2024

Yes, please merge it. I have no merge permissions.

@lubronzhan lubronzhan merged commit 64d9b38 into kube-vip:main Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants