Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CSR utilities on K8s <1.19 #817

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 10, 2022

Fixes #816

Fixes kube-rs#816

Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
@nightkr nightkr force-pushed the bugfix/csr-version-compat branch from 94dd617 to 3f5559e Compare February 10, 2022 14:11
@nightkr nightkr self-assigned this Feb 10, 2022
@nightkr nightkr added api Api abstraction related bug Something isn't working changelog-fix changelog fix category for prs labels Feb 10, 2022
@nightkr nightkr requested a review from a team February 10, 2022 14:18
@nightkr
Copy link
Member Author

nightkr commented Feb 10, 2022

/cc @lukebond, /~https://github.com/influxdata/influxdb_iox/pull/3672

Have confirmed locally that we can now build against v1_16 (the lowest version supported by k8s-openapi), v1_17 and v1_18 again.

@nightkr nightkr merged commit 8ee016a into kube-rs:master Feb 10, 2022
@nightkr nightkr deleted the bugfix/csr-version-compat branch February 10, 2022 19:50
@clux clux added this to the 0.69.0 milestone Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Api abstraction related bug Something isn't working changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-client uses a post 1.19 api resource even if i'm using k8s-openapi v1.17 or v1.18
3 participants