Disable unused default features of chrono crate #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrono crate has some default features that are not used by kube-rs; by disabling them we can avoid pulling in time crate as dependency thus trimming the dependency tree for all users and potentially speeding up compilation time. Signed-off-by: Patryk Obara <dreamer.tan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
==========================================
+ Coverage 71.92% 71.94% +0.02%
==========================================
Files 56 56
Lines 3775 3775
==========================================
+ Hits 2715 2716 +1
+ Misses 1060 1059 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrono crate has some default features that are not used by kube-rs;
by disabling them we can avoid pulling in time crate as dependency thus
trimming the dependency tree for all users and potentially speeding up
compilation time.
Signed-off-by: Patryk Obara dreamer.tan@gmail.com
Motivation
In the project I'm working on we want to get rid of unused
timedependency. This dependency is almost always pulled-in viachronocrate (by optional default featureoldtime), but rarely anyone is using it. Almost all our dependencies already disable the default features onchrono- butkube-rsis the only exception I found so far. Turns out you don't useoldtimefeature either.Solution
Simply disable the default features :)