Make gzip opt-in #399
Merged
Make gzip opt-in #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `gzip` opt-in for now because Kubernetes doesn't have it enabled by default yet and requires more dependencies. It's behind `APIResponseCompression` feature gate which is in `Beta` since 1.16. See <https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/>.
This was referenced Feb 8, 2021
clux
approved these changes
Feb 8, 2021
|
I realized there's no need to branch, so I'll open a new PR simplifying this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
gzipopt-in for now because Kubernetes doesn't have it enabled by default yet and requires more dependencies.It's behind
APIResponseCompressionfeature gate which is inBetasince 1.16.See https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/.
Also, I haven't tested this with compressed response at all.