Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to async-compatible locks in informer and reflector #94

Closed
kitfre opened this issue Nov 30, 2019 · 1 comment
Closed

Switch to async-compatible locks in informer and reflector #94

kitfre opened this issue Nov 30, 2019 · 1 comment

Comments

@kitfre
Copy link

kitfre commented Nov 30, 2019

Currently there are some RwLocks used in informer and reflector that are locked during an async path. This will lock the entire event loop as RwLock is a synchronous construct. Instead using something async compatible like futures::lock::Mutex. Currently there doesn't seem to be any implementations of an async RwLock, but there looks to be some progress towards that end in tokio - tokio-rs/tokio#1665.

This is my bad 🤦‍♂ I should have noticed and included this in #92
@kitfre kitfre mentioned this issue Nov 30, 2019
Merged
@clux
Copy link
Member

clux commented Nov 30, 2019

Fixed in #94.
Thanks again 🙂

@clux clux closed this as completed Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clux @kitfre