Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preconditions is private #459

Closed
ctron opened this issue Mar 11, 2021 · 1 comment · Fixed by #460
Closed

Preconditions is private #459

ctron opened this issue Mar 11, 2021 · 1 comment · Fixed by #460
Labels
api Api abstraction related

Comments

@ctron
Copy link
Contributor

ctron commented Mar 11, 2021

It looks to me as if the type Preconditions of DeleteParams is private.

Is there a reason for this, or just an oversight?
ctron added a commit to ctron/kube-rs that referenced this issue Mar 11, 2021
@ctron
[kube-rs#459]: Make Preconditions public
59f175a
@clux
Copy link
Member

clux commented Mar 11, 2021

Oh, certainly an oversight. Thank you.

@clux clux added the api Api abstraction related label Mar 11, 2021
clux added a commit that referenced this issue Mar 11, 2021
@clux
Merge pull request #460 from ctron/feature/make_public_1
3ededa0 
[#459]: Make `Preconditions` public
@clux clux linked a pull request Mar 12, 2021 that will close this issue
[#459]: Make Preconditions public #460
Merged
@clux clux closed this as completed Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Api abstraction related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#459]: Make Preconditions public ctron/kube-rs
2 participants
@clux @ctron