KTOR-8206 Apply socket and connect timeouts to WS and SSE #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
force-pushed
the
osipxd/websocket-timeouts
branch
from
26188c4 to
a64bdc9
Compare
osipxd
force-pushed
the
osipxd/websocket-timeouts
branch
from
a64bdc9 to
eb4ea1f
Compare
anton-erofeev
pushed a commit
to anton-erofeev/ktor
that referenced
this pull request
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client
Motivation
KTOR-8206 WebSocket and SSE don't respect connection timeout set in the HttpTimeout plugin
Solution
Previously all timeout settings were ignored for WS and SSE requests. I've changed this behavior to ignore only request timeout.