Supports commonly known IDE invisible characters. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HassanTaleb90
commented
Aug 11, 2024
•
HassanTaleb90
commented
Signed-off-by: Hassan Taleb <49780321+HassanTaleb90@users.noreply.github.com>
|
|
Signed-off-by: Hassan Taleb <49780321+HassanTaleb90@users.noreply.github.com>
HassanTaleb90
commented
Aug 11, 2024
HassanTaleb90
changed the title
|
That is not the problem introduced by this PR, just remark that drawing invisible characters is kinda broken at the moment, and the performance is subpar. I'm going to merge these awesome changes, and if you want to think about the outstanding issues, I'm happy to welcome your contribution to make it better.
|
| let frameRect = CGRect(origin: CGPoint(x: segmentFrame.origin.x - layoutFragmentFrame.origin.x, y: segmentFrame.origin.y - layoutFragmentFrame.origin.y), size: CGSize(width: segmentFrame.size.width, height: segmentFrame.size.height)) | ||
|
|
||
| let charSize = symbolString.size(withAttributes: attributes) | ||
| print(frameRect, charSize) |
Signed-off-by: Hassan Taleb <49780321+HassanTaleb90@users.noreply.github.com>
HassanTaleb90
commented
Aug 11, 2024
Co-authored-by: Marcin Krzyzanowski <marcin@krzyzanowskim.com> Signed-off-by: Hassan Taleb <49780321+HassanTaleb90@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.