Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed decode with large binary data #1

Closed
icebob opened this issue May 14, 2021 · 5 comments
Closed

Failed decode with large binary data #1

icebob opened this issue May 14, 2021 · 5 comments

Comments

@icebob
Copy link

icebob commented May 14, 2021

Hi,

There is an issue when I try to encode/decode a larger Buffer data. The same data works with MsgPack.

I made a repro example on repl.it: https://replit.com/@icebob/cbor-issue#index.js

image

@kriszyp
Copy link
Owner

kriszyp commented May 14, 2021

OK, thanks for the great test case, there are some fixes I am working on porting over, so will make sure they address this issue.

@kriszyp
Copy link
Owner

kriszyp commented May 17, 2021

I believe this should be fixed in v0.8 (let me know if you still see the issue).

@icebob
Copy link
Author

icebob commented May 17, 2021

Thanks, the repl.it works, but in the project, now I got a warning:
image
Could you explain what it means?

kriszyp added a commit that referenced this issue May 17, 2021
@kriszyp
Copy link
Owner

kriszyp commented May 17, 2021

This should be fixed with v0.8.2.

@icebob
Copy link
Author

icebob commented May 17, 2021

Thanks, now it looks fine!
If you have time, could you make a changelog.md that I will able to check it (instead of commits) at upgrading in the future? :)

Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants