Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous mode as an add-on #164

Merged
merged 6 commits into from
Feb 20, 2019
Merged

Synchronous mode as an add-on #164

merged 6 commits into from
Feb 20, 2019

Conversation

futpib
Copy link
Contributor

@futpib futpib commented Feb 19, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixes #163

@codecov-io
Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #164   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      7    +3     
  Lines         144    181   +37     
  Branches       42     53   +11     
=====================================
+ Hits          144    181   +37
Impacted Files Coverage Δ
src/UniversalRouter.js 100% <ø> (ø) ⬆️
src/UniversalRouterSync.js 100% <100%> (ø)
src/isChildRoute.js 100% <100%> (ø)
src/resolveRoute.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e32ce...9c36477. Read the comment docs.

Copy link
Member

@frenzzy frenzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 Awesome! 🎉 Thank you!

@frenzzy frenzzy merged commit 2f445f3 into kriasoft:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronous operation
3 participants