Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reexport Contravariant for GHC >= 8.6.1 #70

Closed
chshersh opened this issue Sep 7, 2018 · 3 comments
Closed

Reexport Contravariant for GHC >= 8.6.1 #70

chshersh opened this issue Sep 7, 2018 · 3 comments
Assignees
@kahlil29
Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ reexport Reexport something new

Comments

@chshersh
Copy link
Contributor

chshersh commented Sep 7, 2018

No description provided.

@chshersh chshersh added the reexport Reexport something new label Sep 7, 2018
@vrom911 vrom911 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Sep 30, 2018
@kahlil29
Copy link
Contributor

kahlil29 commented Oct 7, 2018

Is this a complex issue? Any pointers as to how I can go about or start working on this?

@chshersh
Copy link
Contributor Author

chshersh commented Oct 8, 2018

@kahlil29 The issue it quite straightforward. You only need to export some parts of this module:

And the reexport can go into Relude.Functor.Reexport module:

There're only extra parts you need to do:

  1. Use -XCPP extension to export those functions only for when base >= 4.12.0 (GHC 8.6.1)
  2. Most difficult part: what to export and what not to export. Maybe exporting everything is okay. Need only to check, how popular are the names on Hackage with the same names.

@kahlil29
Copy link
Contributor

@chshersh Sorry, I somehow missed this reply earlier, will work on this and submit a PR by today 👍

kahlil29 added a commit to kahlil29/relude that referenced this issue Oct 15, 2018
@kahlil29
[kowainik#70] Reexported Data.Functor.Contravariant for GHC >= 8.6.1.…
b2b26f6 
… Currently exporting all functions from the module as is. Updated Changelog and dhall, hlint
@kahlil29 kahlil29 mentioned this issue Oct 15, 2018
Merged
10 tasks
@kahlil29 kahlil29 self-assigned this Oct 15, 2018
kahlil29 added a commit to kahlil29/relude that referenced this issue Oct 16, 2018
@kahlil29
[kowainik#70] Added explicit exports and commented out warning rules …
f233447 
…(due to them being applicable only for GHC >=8.6.1)
kahlil29 added a commit to kahlil29/relude that referenced this issue Oct 16, 2018
@kahlil29
[kowainik#70] Reexported Data.Functor.Contravariant for GHC >= 8.6.1.…
56ec25d 
… Currently exporting all functions from the module as is. Updated Changelog and dhall, hlint
kahlil29 added a commit to kahlil29/relude that referenced this issue Oct 16, 2018
@kahlil29
[kowainik#70] Added explicit exports and commented out warning rules …
a42fed0 
…(due to them being applicable only for GHC >=8.6.1)
kahlil29 added a commit to kahlil29/relude that referenced this issue Oct 19, 2018
@kahlil29
[kowainik#70] Reexported Data.Functor.Contravariant for GHC >= 8.6.1.…
5e8d6bb 
… Currently exporting all functions from the module as is. Updated Changelog and dhall, hlint
kahlil29 added a commit to kahlil29/relude that referenced this issue Oct 19, 2018
@kahlil29
[kowainik#70] Added explicit exports and commented out warning rules …
c2034d0 
…(due to them being applicable only for GHC >=8.6.1)
kahlil29 added a commit to kahlil29/relude that referenced this issue Oct 19, 2018
@kahlil29
[kowainik#70] Added 3 missing functions to export list and ran stylis…
b9c41e1 
…h-haskell
chshersh pushed a commit that referenced this issue Oct 19, 2018
@kahlil29 @chshersh
[#70] Reexported Data.Functor.Contravariant for GHC >= 8.6.1. (#107)
a177002 
* [#70] Reexported Data.Functor.Contravariant for GHC >= 8.6.1. Currently exporting all functions from the module as is. Updated Changelog and dhall, hlint

* Removed extra space on newline before `#endif`

* [#70] Added explicit exports and commented out warning rules (due to them being applicable only for GHC >=8.6.1)

* [#70] Added 3 missing functions to export list and ran stylish-haskell

* Minor change in CHANGELOG.md

* Minor formatting change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kahlil29 kahlil29

Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ reexport Reexport something new
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chshersh @vrom911 @kahlil29