default value support #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentlauvlwj
requested changes
Sep 17, 2022
| protected open fun <T : Any> visitDefaultValue(expr: DefaultValueExpression<T>): DefaultValueExpression<T> { | ||
| writeKeyword("default ") | ||
| return expr | ||
| } | ||
| } |
There was a problem hiding this comment.
增加新的表达式类型后，除了此处，还需要在 MySqlExpressionVisitor 增加相应的 visit 函数，方便第三方扩展，否则新的表达式会默认派发到 visitUnknown
| writeKeyword("default ") | ||
| return expr | ||
| } | ||
|
|
There was a problem hiding this comment.
同理，新的表达式类型需要在 PostgreSqlExpressionVisitor 增加相应的 visit 函数
|
啊对了，这好像是你第一次给 ktorm 主仓库提 PR，还需要改一下这个文件，在 develpers 里面加上你的信息 |
vincentlauvlwj
approved these changes
Sep 19, 2022
vincentlauvlwj
added a commit
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持mysql、postgresql的
default关键字，可在insert语句中使用相关文档: