Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kokkosinlinefunction to support attributes #299

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

fnrizzi
Copy link
Collaborator

@fnrizzi fnrizzi commented Feb 20, 2023

The current impl of kokkosinlinefunction was only partially working.
This PR fixes it so that we can prepend static, etc

.. role:: cppkokkos(code)
    :language: cppkokkos

.. cppkokkos:kokkosinlinefunction:: double foo1(int const a);

.. cppkokkos:kokkosinlinefunction:: template<class T> double foo1(int const a);

.. cppkokkos:kokkosinlinefunction:: static double foo2(int const a);

.. cppkokkos:kokkosinlinefunction:: explicit constexpr double foo(int a = 0);

Renders as:

image

Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fnrizzi fnrizzi merged commit c991a47 into kokkos:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants