Tweak the wrapValue function to allow for array column operations #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgriesser
added a commit
that referenced
this pull request
May 29, 2014
|
Taken care of in 0.6 - let me know if it doesn't seem to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably not the general-purpose solution to the problem I'm encountering, but it solves my issues. I need to do a join on table.array_column[1] = value, but the existing wrapValue process turns that into "table"."array_column[1]" instead of "table"."array_column"[1]. This seemed like the best place to find that case and fix it.
In where clauses, I could do a whereRaw to brute-force the double-quotes, but there doesn't seem to be a similar functionality in join clauses. That would be another way to solve this problem, though - allow for a join(this.raw("stuff")) (which currently throws a toLowerCase error when compileJoins tries to lowercasify the Raw.