Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable API Gateway v2 (HTTP) for expose #246

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Conversation

gordon-klotho
Copy link
Contributor

@gordon-klotho gordon-klotho commented Feb 16, 2023

This change enables HTTP API Gateways to be created with routes set up.

Standard checks

  • Unit tests: IaC is not unit tested
  • Docs: 🚧
  • Backwards compatibility: ✅

@github-actions
Copy link

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 2%
github.com/klothoplatform/klotho/pkg/annotation 23%
github.com/klothoplatform/klotho/pkg/cli 4%
github.com/klothoplatform/klotho/pkg/core 21%
github.com/klothoplatform/klotho/pkg/env_var 82%
github.com/klothoplatform/klotho/pkg/exec_unit 54%
github.com/klothoplatform/klotho/pkg/infra/kubernetes 59%
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 39%
github.com/klothoplatform/klotho/pkg/input 63%
github.com/klothoplatform/klotho/pkg/lang 38%
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0%
github.com/klothoplatform/klotho/pkg/lang/golang 33%
github.com/klothoplatform/klotho/pkg/lang/javascript 48%
github.com/klothoplatform/klotho/pkg/lang/python 61%
github.com/klothoplatform/klotho/pkg/lang/yaml 0%
github.com/klothoplatform/klotho/pkg/logging 6%
github.com/klothoplatform/klotho/pkg/multierr 95%
github.com/klothoplatform/klotho/pkg/provider/aws 60%
github.com/klothoplatform/klotho/pkg/runtime 78%
github.com/klothoplatform/klotho/pkg/static_unit 33%
github.com/klothoplatform/klotho/pkg/validation 73%
github.com/klothoplatform/klotho/pkg/yaml_util 79%
Summary 41% (3975 / 9657)

apiId: api.id,
integrationType: 'HTTP_PROXY',
integrationMethod: 'ANY',
integrationUri: ecsNlb.loadBalancer.arn,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will only work if the nlb is an awsx nlb which i think we moved completely off of now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought we migrated away from it but we didnt

@DavidSeptimus
Copy link
Contributor

Do we want to update the signature of core.NewGateway() to require an ApiType value?

@gordon-klotho
Copy link
Contributor Author

Do we want to update the signature of core.NewGateway() to require an ApiType value?

core.Gateway wasn't changed, only the config types so no update necessary

@gordon-klotho gordon-klotho merged commit 607fdaf into main Feb 16, 2023
@gordon-klotho gordon-klotho deleted the feature/apigateway_v2 branch February 16, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants