-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config capability and use in go secrets #242
Conversation
@@ -2,12 +2,10 @@ FROM golang:1.20 as builder | |||
|
|||
WORKDIR /usr/src/app | |||
ENV GOOS=linux GOARCH=amd64 CGO_ENABLED=0 | |||
COPY go.mod ./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check (since I know you have a bunch of changes in flight), did you meant to commit these changes into this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah the dockerfile changes are necessary to get this to work
383cb1c
to
524bc75
Compare
|
• Does any part of it require special attention?
• Does it relate to or fix any issue?
this is a follow on to #240
This adds the @KLOTHO::config capability
We add this to config, topology, and validation.
This includes the changes to the go secrets plugin to look for klotho::config with the directive of secret = true
Standard checks