Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defaults dependency to 8.2 #1111

Merged
merged 5 commits into from
Feb 25, 2025
Merged

Conversation

BPerlakiH
Copy link
Collaborator

@BPerlakiH BPerlakiH commented Feb 13, 2025

Fixes: #1104

Tested on iPad, iPhone and macOS.

Updating not to the latest version, but the highest we can still run on Xcode 15.4

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Project coverage is 35.56%. Comparing base (4de2be6) to head (1cc64db).

Files with missing lines Patch % Lines
ViewModel/BrowserViewModel.swift 37.50% 10 Missing ⚠️
Views/Bookmarks.swift 0.00% 3 Missing ⚠️
ViewModel/NavigationViewModel.swift 0.00% 2 Missing ⚠️
App/CompactViewController.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   34.28%   35.56%   +1.27%     
==========================================
  Files         138      137       -1     
  Lines        7857     7859       +2     
==========================================
+ Hits         2694     2795     +101     
+ Misses       5163     5064      -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 force-pushed the 1104-update-defaults-dependency branch from 0fa640e to 2ba79c7 Compare February 14, 2025 08:50
@kelson42 kelson42 force-pushed the 1104-update-defaults-dependency branch from 2ba79c7 to cfc9387 Compare February 15, 2025 12:22
Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI does not pass

@kelson42 kelson42 force-pushed the 1104-update-defaults-dependency branch from cfc9387 to f143157 Compare February 16, 2025 22:05
@kelson42 kelson42 force-pushed the 1104-update-defaults-dependency branch from f143157 to 5a8ab8f Compare February 19, 2025 17:10
@BPerlakiH BPerlakiH force-pushed the 1104-update-defaults-dependency branch from 5a8ab8f to 6bacbc7 Compare February 22, 2025 13:45
@BPerlakiH BPerlakiH changed the title Update defaults dependency Update defaults dependency to 8.2 Feb 22, 2025
@BPerlakiH BPerlakiH force-pushed the 1104-update-defaults-dependency branch from 57fb62a to 6cf2f6d Compare February 22, 2025 20:07
@BPerlakiH
Copy link
Collaborator Author

This one should build OK, once updated with the revert from: #1123

@BPerlakiH BPerlakiH force-pushed the 1104-update-defaults-dependency branch from 6cf2f6d to 9e748fe Compare February 23, 2025 18:10
@BPerlakiH BPerlakiH requested a review from kelson42 February 23, 2025 19:33
@kelson42 kelson42 merged commit 0ef04dc into main Feb 25, 2025
8 checks passed
@kelson42 kelson42 deleted the 1104-update-defaults-dependency branch February 25, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Defaults dependency
3 participants