Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change url type to be copied for macOS, remove id from menu #1103

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #1099

macOS (right clicking on a catalog item)
Screenshot 2025-02-07 at 11 45 39

iOS (long pressing on a catalog item)
Screenshot 2025-02-07 at 11 47 03

@BPerlakiH BPerlakiH linked an issue Feb 7, 2025 that may be closed by this pull request
@BPerlakiH BPerlakiH requested review from rgaudin and kelson42 February 7, 2025 10:49
@BPerlakiH
Copy link
Collaborator Author

it seems like our localisation validator is already doing a good job :) Just discovered an unused entry after my changes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.40%. Comparing base (e14241f) to head (8404939).

Files with missing lines Patch % Lines
Views/Library/Library.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
+ Coverage   35.35%   35.40%   +0.04%     
==========================================
  Files         134      134              
  Lines        7732     7723       -9     
==========================================
  Hits         2734     2734              
+ Misses       4998     4989       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit a8c6dc9 into main Feb 7, 2025
8 checks passed
@kelson42 kelson42 deleted the 1099-fix-macos-menu-copying-zim-url branch February 7, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying Zim File Cell URL can't paste in terminal
4 participants