-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve launch sequence for custom apps #1008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 39.86% 38.26% -1.60%
==========================================
Files 116 118 +2
Lines 6618 6879 +261
==========================================
- Hits 2638 2632 -6
- Misses 3980 4247 +267 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1006
There must be quite some changes to achieve this.
Custom apps (the ones without catalog / library capability) have a different loading
sequence compared to Kiwix app, since we do not have the "Fetching catalog" part.
Also the views were too tightly coupled with the loading states and library. Eg: Welcome screen was coupled with WebView.
I separated out the sequence of loading and its possible states into a new place, and wrapped that into a protocol with 1 implementation for Kiwix, and one for custom apps without Library.
I have re-tested both Kiwix and custom apps on iPhone iPad and macOS.