-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the file picker in play store variant for move or copy the zim files in application's public directory #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3979 +/- ##
============================================
- Coverage 57.81% 57.73% -0.08%
- Complexity 1572 1575 +3
============================================
Files 310 311 +1
Lines 12549 12865 +316
Branches 1590 1641 +51
============================================
+ Hits 7255 7428 +173
- Misses 4246 4347 +101
- Partials 1048 1090 +42 ☔ View full report in Codecov by Sentry. |
9c815f7
to
a5b967f
Compare
…files in application's public directory
* Improved the showing of progressBar to inform the user about the copy/moving progress.
…ct API fails to move the document, a fallback method will copy the source file and delete the original file, ensuring a smooth user experience. * Improved file copying performance: To enhance copy speed, we now use FileChannel for copying files, which is faster than the standard InputStream operation.
* Using the error message from string file instead of a hardcoded string.
…properly test the all scenario with edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3941
OnBackInvokedCallback
, which was not enabled for the application.SearchFragment
,KiwixPrefFragment
, andLanguageFragment
.unit
andinstrumentation
test cases for testing the whole functionality with edge cases.screen-20240903-183347.mp4
The above video shows the whole functionality.